Skip to content

remove deprecated NFT embed functionality #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

remove deprecated NFT embed functionality #6136

merged 1 commit into from
Jan 31, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 31, 2025 •
edited by pr-codex bot
Loading

fixes: CORE-720

PR-Codex overview

This PR focuses on the removal of certain components and functions related to embedding functionality in the dashboard, as well as modifications to API key handling.

Detailed summary

  • Deleted the following files:
    • page.tsx
    • embed-setup.tsx
    • EmbedSetup.client.tsx
  • Removed the "Embed" section from the sidebar links.
  • Modified the useApiKeys function to remove its implementation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 10:21pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 31, 2025 10:21pm
login ⬜️ Skipped (Inspect) Jan 31, 2025 10:21pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 31, 2025 10:21pm
wallet-ui ⬜️ Skipped (Inspect) Jan 31, 2025 10:21pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 22:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 22:10 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: daceeed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login January 31, 2025 22:10 Inactive
@linear
Copy link

linear bot commented Jan 31, 2025

CORE-720 Remove `Embed` from contract pages

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 31, 2025
@jnsdls jnsdls marked this pull request as ready for review January 31, 2025 22:10
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Jan 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls requested review from a team as code owners January 31, 2025 22:10
@codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (5f7c726) to head (daceeed).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6136   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5184     5184           
=======================================
  Hits        36353    36353           
  Misses      26815    26815           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5f7c726
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 3.1 s (+8.88% 🔺) 4.1 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 6.5 s (+27.79% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 275 ms (-15.3% 🔽) 387 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 95 ms (+79.23% 🔺) 105 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 703 ms (+44.49% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 31, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the remove_deprecated_NFT_embed_functionality branch from 42a4fe6 to daceeed Compare January 31, 2025 22:18
@vercel vercel bot temporarily deployed to Preview – login January 31, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 22:18 Inactive
@graphite-app graphite-app bot merged commit daceeed into main Jan 31, 2025
32 checks passed
@graphite-app graphite-app bot deleted the remove_deprecated_NFT_embed_functionality branch January 31, 2025 22:21
@vercel vercel bot temporarily deployed to Production – login January 31, 2025 22:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 31, 2025 22:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 31, 2025 22:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 31, 2025 22:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @gregfromstl